Fix issue #12 branches with / in it are cut-off #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the cut off branch names when a branch has a / in the name. Example: "dev/2.7.x" was cut off to "2.7.x".
|
LGTM - thanks for the help! I was on vacation for the past two weeks so I didn't see this until now. I'll merge it tomorrow. |
mrkline
added a commit
that referenced
this pull request
May 15, 2015
Fix issue #12 branches with / in it are cut-off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the cut off branch names when a branch has a / in the name.
Example: "dev/2.7.x" was cut off to "2.7.x".
Let me know what you think.
I left the original logic intact in case there are only two / in the
ref:line, but otherwise it will chomp off the wholeref: refs/heads/part and return everything after that. Not sure if this is the ideal solution, but it seems to work in this case.PS: I installed this tool on our servers and my coworkers love it. Thanks again.